You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No business logic exists within the database layer
DB migrations: none in this PR
PR title and every commit are conventional commits
Description of the change
Spell "Transferred" correctly in the frontend: the EnrollmentStatus enum in attendance.ts, the Exports roster filter option and non-completing set, and the Programs tooltip. The roster filter now sends Transferred, matching the unlocked-programs change.
Related issues: EN-244
Release
Changelog type: fix
Breaking change?: no !, but see below.
Additional context
Depends on the unlocked-programs EN-244 PR. The filter label changes together in both repos, so merge and deploy them together.
The ticket's backend code moved to unlocked-programs in EN-207, so this PR holds only the frontend change plus docs/plans/EN-244-transferred-spelling/.
Core migrations 00055 and 00074 still contain the old spelling. They are applied history, and rewriting them would be wrong.
EnrollmentStatus and export references now use Transferred instead of Transfered. The past-enrollments tooltip spelling is also corrected.
Merge Risk: Minimal · up to 8482a
No merge-blocking issue was identified. Deploy the paired Programs changes together.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly summarizes the frontend spelling correction and identifies the related ticket.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description states the PR corrects the misspelling "Transfered" to "Transferred" across the EnrollmentStatus enum in attendance.ts, the Exports roster filter option and non-completing set, and the…
Full details: Description check
Explanation
The description states the PR corrects the misspelling "Transfered" to "Transferred" across the EnrollmentStatus enum in attendance.ts, the Exports roster filter option and non-completing set, and the Programs tooltip. It also explains the dependency on the unlocked-programs EN-244 change, the migration handling, and the changelog type. It matches the changeset, so the check passes.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 87e4f2a6-611c-4924-89f7-209a69e07786
Commits
Reviewing files that changed from the base of the PR and between cfa45f5 and 8482a8b.
Files selected for processing: 3
frontend/src/pages/ProgramsPage.tsx
frontend/src/pages/admin/Exports.tsx
frontend/src/types/attendance.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Hey @CK-7vn, found a couple of things before it merges:
Please drop docs/plans/EN-244-transferred-spelling/. Core doesn't keep a docs/plans folder; this PR would be the first thing in it. The three files are working notes, mostly about the Programs repo. They also don't match the code: plan.md says 00004's Down reverses the change, but it's a no-op. The PR description and the Programs PR already cover the useful parts.
Checklist. "Tested manually" and "All acceptance criteria verified" are ticked, but your own verification notes list the browser check of the Exports roster filter as UNVERIFIED. Please run it together with the Programs PR: transfer a resident, filter the roster report by Transferred, and check that the class outcomes show it. Then tick it. "Branch rebased" is ticked too, but the branch is on b387158b, and main has moved since (#1294). Nothing conflicts; it just needs the rebase.
A platform PR moves staging's programs.tag to the matching Programs build. This PR goes to staging by itself as soon as it merges, so do that platform PR at the same time.
Browser check. "Tested manually" and "All acceptance criteria verified" are still ticked, but nothing shows the roster filter check was run. It needs the Programs side too, so the easiest place is staging, once both are merged. Untick those two boxes until then.
What has to happen before EN-244 can close:
unlocked-programs #6 is approved and merged. It's failing govulncheck right now; it needs the Go 1.26.11 bump (in programs #12, or bump it in #6).
This PR is merged. It goes to staging by itself, so merge it together with the next item.
A platform PR moves staging's programs.tag (still sha-1e177e7) to the Programs build that has #6.
On staging: transfer a resident, filter the roster report by Transferred, and check that the class outcomes show the transfer.
The Jira "Repo" line still says unlocked-core only. Please add unlocked-programs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
documentation
carddev81
left a comment
Pre-Submission PR Checklist
Description of the change
Spell "Transferred" correctly in the frontend: the EnrollmentStatus enum in attendance.ts, the Exports roster filter option and non-completing set, and the Programs tooltip. The roster filter now sends Transferred, matching the unlocked-programs change.
Release
Additional context